moewew / biblatex-trad

traditional bibliography styles with biblatex
LaTeX Project Public License v1.3c
31 stars 7 forks source link

Comma after journal name #1

Closed russella closed 11 years ago

russella commented 11 years ago

First of all, thank you for all your work on this. I was just beginning a similar project (but only for plain), so your timing is impeccable!

In case it is helpful for you, I'll post comments here as they arrive.

First of all, many journal names are abbreviated (e.g., SIAM J. Comput.), and this confuses your biblatex code into thinking that there is already punctuation there (so that the following comma is missing). I fixed this with the code:

\renewbibmacro*{journal+issuetitle}{%
  \usebibmacro{journal}\isdot%

...

at the beginning of journal+issuetitle. I believe that the \isdot will ensure that any period used for a journal abbreviation is understood as a "nonpunctuation" period.

I hope this is welcome.

Regards, Alex

marcodaniel commented 11 years ago

Hi Alex,

thanks for your feedback and your report. Of course it's welcome! I will fix this issue at the weekend and then I will upload the new version.

Best regards Marco

marcodaniel commented 11 years ago

Hi Alex,

as I promised this weekend I am working on the open issues. The missing comma can be fixed by the following line:

\DeclareFieldFormat{journaltitle}{\mkbibemph{#1}\isdot}

I prefer this way because it's much clearer and the user can change the behavior more flexible.

Regards Marco