search

moezbhatti / qksms

The most beautiful SMS messenger for Android
https://qklabs.com/download
GNU General Public License v3.0
4.48k stars 1.06k forks source link

Contrast issues when theme color is close to background color #1274

Open fazlerabbi37 opened 6 years ago

fazlerabbi37 commented 6 years ago

DESCRIPTION

When Nigh mode is on, buttons like call button on top of a conversation, toggle buttons like 'Pure black night mode' or 'Use system font', specially when turned on are not visible. Turning 'Pure black night mode' on makes the buttons barely visible. I think while Night mode is on, it should be of invert coler similar to the 'Archive' and 'Delete' button that shows after selecting the conversations and for 'Pure black night mode' the opacity of the buttons should be increased to make them more visible.

STEPS

  1. To go settings
  2. Turn night mode to 'Always on'
  3. Toggle to turn on the 'User system font'
  4. Now toggle to turn on the 'Pure black night mode'

EXPECTED

In both step 3 and 4 buttons should be visible.

OBSERVATIONS

On step 3 buttons loses complete visibility and one step 4 the become barely visible.

Please look into it.

moezbhatti commented 6 years ago

Can you post a screenshot of one of these screens for me?

fazlerabbi37 commented 6 years ago

Sure. I am attaching 4 images. First 3 image is for setp 2-4 and image 4 is for inverted coler reference.

Setp 2: 1

Setp 3: 2

Setp 4: 3

Inverted color reference: 4

Hope it helps.

moezbhatti commented 6 years ago

Perfect, thank you. Looks like this is also an issue if you're using the light mode and you pick a theme color that's too light

dtar2 commented 6 years ago

I think the 4th screenshot above is related to issue #1232.