search

moezbhatti / qksms

The most beautiful SMS messenger for Android
https://qklabs.com/download
GNU General Public License v3.0
4.42k stars 1.06k forks source link

Support RCS API (if available) #1522

Open miladmaz12 opened 4 years ago

miladmaz12 commented 4 years ago

DESCRIPTION

A short description of the issue. Example: Conversations aren't marked as read when they are opened from a notification.

STEPS

  1. Steps
  2. to
  3. reproduce
  4. the
  5. issue.

EXPECTED

Describe the expected behaviour.

OBSERVATIONS

Describe what happens instead of the expected behaviour.

mkeedlinger commented 4 years ago

I'll add a little bit of context since the body of this issue doesn't have much.

RCS brings iMessage like functionality to Android in a cross-carrier, standardized fashion. The protocol and efforts to bring support for it have been spear-headed by Google, and in a recent post they announced RCS would be rolled out soon, but that it is currently mainly supported by their Messages app.

RCS is awesome, having support for it in an OSS implementation would be incredible.

Aside: Thanks for this app, it's the only real OSS messaging alternative I can find on fdroid

e-t-l commented 4 years ago

One thing to consider is the switch between SMS/RCS. AFAIK, Google Fi is the only carrier that doesn't charge data usage for RCS messages, so it might be handy to have an option that enables RCS only over wifi, for users who don't want to eat up their data allowance. It's also the responsibility of the SMS app to automatically re-send RCS messages as SMS if the phone doesn't have a data connection. Android Messages already has the latter feature (although I haven't been able to test it out), but I think implementation of the former would be an excellent feature to include in an OSS app.

moezbhatti commented 4 years ago

I'd love to implement it as soon as it's possible to, but unfortunately we're still waiting on the public API from Google

AyoungDukie commented 3 years ago

Just to bump, it looks like RCS has *started to be implemented outside of Google Messages, at least a couple apps in the Play Store and apparently the OnePlus messaging app

iot-resister commented 3 years ago

@moezbhatti

https://github.com/android-rcs/rcsjta

Thanks to its client/server API, the stack may be easily integrated with existing native Android applications (e.g. address book, dialer) and permits to create new RCS applications (e.g. chat, widgets).

Can I sponsor this feature?

@AyoungDukie only available to oems

https://9to5google.com/2019/07/30/android-rcs-apis-oems-not-third-party-apps/

eternaltyro commented 3 years ago

This will be an awesome feature to have. I'll be willing to chip in a little bit to sponsor this feature as well; as I'm sure others using the app also will.

phpbg commented 3 years ago

I'd love to implement it as soon as it's possible to, but unfortunately we're still waiting on the public API from Google

RCS is supposed to be a standard. Can't it be implemented from scratch?

iot-resister commented 3 years ago

@phpbg https://github.com/android-rcs/rcsjta

eternaltyro commented 3 years ago

@phpbg We should not have to implement it from scratch because maintaining it would be difficult. Existing implementations used by multiple products will be subject to more scrutiny and therefore (intuitively) might be better in terms of performance and security. So It's better to use a good third-party library with permissive license.

phpbg commented 3 years ago

@phpbg We should not have to implement it from scratch because maintaining it would be difficult. Existing implementations used by multiple products will be subject to more scrutiny and therefore (intuitively) might be better in terms of performance and security. So It's better to use a good third-party library with permissive license.

Agree, but I cannot find any actively maintained and open source library... :-/

freshgum-bubbles commented 2 years ago

@iot-resister that library you sent seems to be abandoned... are there any viable boil-in-a-bag client library alternatives?

It looks a bit like an open-but-closed Google standard. The fact that we haven't had a decent maintained library for it in over 4 years should raise eyebrows, and perhaps hint at the complexity behind RCS, or some sort of intention to keep it out of an open-source library, as is the usual way with Google.

I doubt RCS is coming to QKSMS soon...

jtagcat commented 2 years ago

jfyiya: RCS and RCS are different things. One is Google's, other is generic.

jtw023 commented 2 years ago

Can I sponsor this feature?

I would sponsor this feature in a heartbeat! Be sure to push a notification out alerting people when an OSS implementation of this becomes a real possiblity. I'm sure a large portion of your user base would be willing to sponsor as well.

markcellus commented 2 years ago

I'd sponsor this also, for sure 👍

Tobias-Lauerbach commented 2 years ago

I'd love to implement it as soon as it's possible to, but unfortunately we're still waiting on the public API from Google

I hve found this APP which looks nearly identical (possibpy a fork) and sas it woud support rcs but i coudnt confirm it..., but mayby it helps https://github.com/vidit135g/Replify-Messenger

@moezbhatti

markcellus commented 1 year ago

I took a look at https://github.com/vidit135g/Replify-Messenger. I wouldn't recommend people use it.

  1. The code in the repository doesn't appear to be integrating RCS, so saying it does in the README isn't truthful
  2. The only edit that I can see after the initial code was copied into this repo is a change to the README and a credit to QKSMS. This is also a little disingenuous because not forking the QKSMS repository makes it difficult to see any diffs or specific edits this maintainer has made to the QKSMS code before copying it.
  3. The app in the Google Play store shows that it's owned by a company called "The Absolute Corporation" with a gmail address and has what appears to be a fake business address.

These are just a few of the red flags and time is limited to list them all, but they are enough for me to stay far away from it. Additionally, the feature set seems to be a full copy of the QKSMS and the last release is years older than QKSMS. There's no reason to use this Replify-Messenger app.

ilmaisin commented 7 months ago

https://github.com/Hirohumi/rust-rcs-core

Someone seems to be working on a RCS client library.

The bigger question is: which server it could be used to connect to? Very few carriers provide RCS servers of their own, and many have actually shut down their ones in favour of Google Jibe.

I am not sure what RCS in its current iteration means to AOSP phones, or things like Pinephone and Librem 5? Will corporations such as Google, Apple and Huawei be the only ones that can build modern texting apps?

YannBirba commented 3 weeks ago

Do you have any news about RCS support in qk ?

onyxcode commented 2 weeks ago

Would love to see this added to QK, I absolutely despise Google Messages and now they're blocking RCS for rooted/custom rom installs of Android.