moezbhatti / qksms

The most beautiful SMS messenger for Android
https://qklabs.com/download
GNU General Public License v3.0
4.48k stars 1.06k forks source link

Deleted items not updated during search and crash. #1827

Open acorreya opened 3 years ago

acorreya commented 3 years ago

DESCRIPTION

Getting back to search from deleting messages still show them in results. If the list of messages (grouped by contact) is empty, app crashes. Crash log attached

STEPS

  1. Search for something in main page
  2. Select a contact and delete the SMS listed (I searched for "OTP" and deleted the ones with "OTP")
  3. Two possibilities: a. If contacts are now empty becaues all messages are deleted. b. OR having messages with no search keyword
  4. Go back to search page. The contact (sometimes with no SMS) is still visible
  5. Open the contact to view (sometimes with non-existent) messages a. If the contact does not have messages under it, BOOM. b. Otherwise, the contact opens, but has no messages matching keyworkd.

EXPECTED

After deleting the SMS under the contact, going back to search should not show the contact under search results.

OBSERVATIONS

Contacts now not having the search keyword still appear in search. If that contact has no SMS under it, app crashes.

qksms-crash.log