moezbhatti / qksms

The most beautiful SMS messenger for Android
https://qklabs.com/download
GNU General Public License v3.0
4.47k stars 1.06k forks source link

Text contrast varies too much due to differing color shades #1920

Open bryanparadis opened 1 year ago

bryanparadis commented 1 year ago

DESCRIPTION

The app inverts the text from black to white based on how light/dark the color is. I like the automatic colors but I am finding it really difficult to read some combinations.

I would love to be able to limit the color palette to all dark colors + light text, all light colors + dark text or cut it down to just the highest contrast combinations.

White text on bright orange is one of the exceptionally hard to read ones.

STEPS

  1. Open the Contact color selector
  2. Browse through all the orange or yellow selections and look at the check mark contrast

EXPECTED

Text should always be matched to a high contrast color

OBSERVATIONS

Text varies from very easy to read to very difficult necessitating a color change

accellarando commented 2 months ago

I've noticed two places that the contrast is an issue: the "Apply" check mark contrast in the "QKSMS" color pick tab, and in the actual text bubbles. I'm on dark theme, /e/OS Message v3.9.4.

Ideally the app should be compliant with WCAG accessibility standards. Color contrast is defined here, and text should have a ratio of at least 4.5:1 or, even better, 7:1.

I found a Java contrast calculator here.

Apply button is always white text, which does not work for lighter backgrounds: IMG_20240717_100944

Then the message text is always black, which does not work for darker backgrounds: Screenshot_20240717-100859_Message