moezbhatti / qksms

The most beautiful SMS messenger for Android
https://qklabs.com/download
GNU General Public License v3.0
4.47k stars 1.06k forks source link

(Contact) phone number updates do not appear in QKSMS when used to share a contact details #1938

Open cmvizitiu opened 1 year ago

cmvizitiu commented 1 year ago

DESCRIPTION

Changes to the phone number of a given contact (with an already existing valid SMS conversation) do not propagate into QKSMS when invoked from the Contacts app as a share target.

STEPS

  1. Attempt a "share contact details" from the Contacts app, chose QKSMS
  2. Chose an existing conversation thread from QKSMS
  3. Press send
  4. Mobile network operator sends back a SMS claiming that the phone number is invalid. Notice that the number displayed by the network provider error SMS doesn't have the international prefix.
  5. Having dealt with this issue before (in a different context), switch to Contacts app and modify the contact so that its number starts with "00" instead of "+"
  6. Attempt again a "share contact" from Contacts app, chose QKSMS
  7. Notice that QKSMS still displays the old phone number (starting with "+"); sending the message again will result in the same error sent back by the network provider

EXPECTED

QKSMS should have picked up the given contact modification(s). Alternatively, an option under contact details (e.g. between "Notifications" and "Archive") would allow for a "Contact Refresh" or "Refresh Contacts DB" or equivalent.

OBSERVATIONS

This looks like a case of stale cache. Neither force stopping the app nor "clear cache" option from system settings would make a difference. I even tried forcing the SMS number directly: I copied the updated number from the contact and instead of choosing an existing thread I pasted the number (that is the one with "00" prefix) into QKSMS's input field. QKSMS picked the existing thread but sending resulted once gain in an error; it was still matching the old number. Ultimately it was the "delete all app data" that did the trick. After this, the QKSMS listing was empty and pasting the number brought up the existing thread after a second or two but this time it had the correct phone number so the SMS went out correctly.

Also I would like to notice that QKSMS itself doesn't seem to be affected by the "+" sign in front of the number as the other SMS already sent prove it (nor is the dialing app for that matter). So it would appear as if the bug only manifests itself when choosing share via SMS from Contacts app.

QKSMS 3.10.1 (Samsung) Android 13 sp 1 March 2023 kernel 5.4.147