search

moff / angular2-flash-messages

Angular 2 flash messages module
52 stars 21 forks source link

Angular 7 Support #49

Open daveparks23 opened 5 years ago

daveparks23 commented 5 years ago

npm WARN angular2-flash-messages@3.0.1 requires a peer of @angular/core@^6.0.0 but none is installed. You must install peer dependencies yourself.

Would love to use this on Angular 7.x Thanks for all you do. Let me know if I could help in some way.

smmgsm commented 5 years ago

same issue

JoSSte commented 5 years ago

In my experience it works fine, even though the warnings appear... I'd like them to disappear though...

Psyfo commented 5 years ago

Just checking to see if there are any plans for an update? So far nothing seems to have changed as mentioned above but I would also like to see the warnings disappear.

jankrumrey commented 5 years ago

Since it's just a peer dependency warning, and the module is working fine with Angular 7, I made the warnings disappear by changing the peer dependency on angular core in angular2-flash-messages' package.json to ^7.0.0.