moflo / openspringboard

UIKit based Spingboard clone, similar to Three20's TTLauncherView. (Update Aug-9-2011: finally have time to refactor this for iOS5 custom container view controllers)
http://fieldforceapp.com
MIT License
242 stars 38 forks source link

Items can be opened when dancing #10

Open Hjcrbwg opened 12 years ago

Hjcrbwg commented 12 years ago

While the items are dancing, if the user taps on a dancing item, it will open that item and freezes the page for a few seconds. It should either do nothing, or switch to that item as the one the user wants to move. Please fix this ASAP!

moflo commented 12 years ago

Add the following to line #92 of the launchTool:sender method in OpenSpringBoard.m:

if (isIconAnimating) { return; }

We will post a full patch soon.

Hjcrbwg commented 12 years ago

Actually, I found this on around line 405:

[UIView animateWithDuration:0.2
                            delay:0.0
                          options:UIViewAnimationOptionRepeat | UIViewAnimationOptionAllowUserInteraction
                       animations:^{
                           view.transform = CGAffineTransformTranslate(CGAffineTransformIdentity, kAnimationTranslateX, kAnimationTranslateY);
                           view.transform = CGAffineTransformMakeRotation(kAnimationRotateDeg*(i%2 ? -1 : +1)*(3.141519/180.0));
                       }

Deleting the <UIViewAnimationOptionAllowUserInteration> part of the code removes the issue.

Note: this may not be exactly what the code was for that part as I have been experimenting with it a little.

moflo commented 12 years ago

Looks good. Submit a pull request is possible & I'll merge.