Some updates - Githubissues

mofosyne / arduino-gameboy-printer-emulator

Code to emulate a gameboy printer via the gameboy link cable

https://mofosyne.github.io/arduino-gameboy-printer-emulator/

GNU General Public License v3.0

318 stars 41 forks source link

Some updates #15

Closed BjornB2 closed 4 years ago

BjornB2 commented 4 years ago

Removed imgur code (wasn't working for me)
Added a download button which downloads a jpg version of the canvas with a filename including date.
Removed two of the 3 sample photos.
Changed background to white.

mofosyne commented 4 years ago

Thanks mate! It works and looks good!

mofosyne commented 4 years ago

If you want to make a credit page feel free to :)

BjornB2 commented 4 years ago

Cool thanks for the merge. What do you mean with credit page?

mofosyne commented 4 years ago

Just something so we can track who helped out with this project :)

I'm not too sure how it should look. But I'm guessing it could be a CONTRIBUTOR.txt page... or I think easier is to just add a new section to the readme called contributors.

I should probbly also remember to add virtuaCode's to the readme page as well to thank him for his pull that I merged into my code as well https://github.com/mofosyne/arduino-gameboy-printer-emulator/pull/9

mofosyne commented 4 years ago

Actually... I'll do the change myself.

mofosyne commented 4 years ago

Done https://github.com/mofosyne/arduino-gameboy-printer-emulator/blob/master/README.md#contributors--thanks

BjornB2 commented 4 years ago

Cool 😊