current svn checkout doesn't compile

[GoogleCodeExporter]

make fails with:

Making all in src
make[2]: Entering directory `/usr/src/web10g/ndt-web10g/src'
gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/local/include/web100 -I/usr/include/pcap 
-I/usr/local/include/estats -I../I2util  '-DBASEDIR="/usr/local/ndt"'   
-pedantic -Wall -fno-strict-aliasing -std=gnu99 -DNDEBUG -O2 
-DEXPERIMENTAL_ENABLED -DDATABASE_ENABLED -MT web10gsrv-web100-util.o -MD -MP 
-MF .deps/web10gsrv-web100-util.Tpo -c -o web10gsrv-web100-util.o `test -f 
'web100-util.c' || echo './'`web100-util.c
web100-util.c: In function ‘tcp_stat_init’:
web100-util.c:136:10: error: ‘TOTAL_INDEX_MAX’ undeclared (first use in 
this function)
   return TOTAL_INDEX_MAX;
          ^
web100-util.c:136:10: note: each undeclared identifier is reported only once 
for each function it appears in
web100-util.c: In function ‘tcp_stat_get_data’:
web100-util.c:679:9: warning: unused variable ‘str’ [-Wunused-variable]
   char *str = NULL;
         ^
web100-util.c: In function ‘CwndDecrease’:
web100-util.c:1081:8: warning: unused variable ‘buff’ [-Wunused-variable]
   char buff[256];
        ^
web100-util.c: In function ‘tcp_stat_init’:
web100-util.c:138:1: warning: control reaches end of non-void function 
[-Wreturn-type]
 }
 ^
web100-util.c: In function ‘tcp_stat_middlebox’:
web100-util.c:308:11: warning: ignoring return value of ‘system’, declared 
with attribute warn_unused_result [-Wunused-result]
     system("echo 1 > /proc/sys/net/ipv4/route/flush");
           ^
make[2]: *** [web10gsrv-web100-util.o] Error 1
make[2]: Leaving directory `/usr/src/web10g/ndt-web10g/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/usr/src/web10g/ndt-web10g'
make: *** [all] Error 2

Original issue reported on code.google.com by ralf.hil...@gmail.com on 6 Jan 2015 at 3:00

[GoogleCodeExporter]

This is with web10g-userland-2.0.9 and web10g-0.11-3.17.diff applied against 
kernel 3.17.7

Original comment by ralf.hil...@gmail.com on 6 Jan 2015 at 3:55

[GoogleCodeExporter]

The problem is related to TOTAL_INDEX_MAX variable being removed from types.h 
since userland v2.0.8.

Original comment by skost...@soldevelo.com on 9 Jan 2015 at 5:08

[GoogleCodeExporter]

So which versions "fit together"?

Original comment by ralf.hil...@gmail.com on 12 Jan 2015 at 8:59

[GoogleCodeExporter]

I'm testing it using web10g-userland-2.0.7 and web10g-0.7-3.9.patch applied 
against 3.9.1 kernel.

Original comment by skost...@soldevelo.com on 12 Jan 2015 at 10:14

[GoogleCodeExporter]

Would this be a trivial fix before doing a release?

Original comment by AaronMat...@gmail.com on 13 Mar 2015 at 3:20

[GoogleCodeExporter]

Original comment by skost...@soldevelo.com on 19 Mar 2015 at 11:01

• Changed state: Accepted

[GoogleCodeExporter]

On Issue167 branch I've commited fix which solves mentioned problem. In 
versions above 2.0.7 of userland TOTAL_INDEX_MAX variable was renamed and moved 
to another file. Now it should compile fine on every version of it. Please tell 
me if this changes are ok and can be merged into trunk.

Original comment by skost...@soldevelo.com on 19 Mar 2015 at 12:22

• Changed state: Complete

[GoogleCodeExporter]

The change looks fine. Did you test on both old and new userland installs?

Original comment by AaronMat...@gmail.com on 19 Mar 2015 at 5:16

[GoogleCodeExporter]

Yes, I've tested on 2.0.7 and newest 2.0.9 userlands and it compiles fine on 
both.

Original comment by skost...@soldevelo.com on 20 Mar 2015 at 8:29

[GoogleCodeExporter]

Commit at will then

Original comment by AaronMat...@gmail.com on 20 Mar 2015 at 11:53

[GoogleCodeExporter]

Merged into trunk

Original comment by skost...@soldevelo.com on 20 Mar 2015 at 12:10

• Changed state: Fixed