mogaika / god_of_war_browser

https://discord.gg/u6x3Z9v6Ed
47 stars 25 forks source link

Texture replacer incorrectly handle situations when same palette used in different textures #5

Closed mogaika closed 4 years ago

mogaika commented 4 years ago

I'm sorry, I was not as specific as the error, I can replace the textures, but in particular those of kratos, the first two textures of kratos, if I replace each other gets blurry, and vice versa ... in terms of tools I wanted them to replace the curtscenes of the game (pss) image

_Originally posted by @leonifc331 in https://github.com/mogaika/god_of_war_browser/issues/1#issuecomment-570742735_

Problem in these two particular textures TXR_maiF02 and TXR_maiF01. They both use same palette PAL_MAI01F, so when you change one the texture, you breaks palette for other one texture. gow-browser currently can't handle such situations. I can add "Add own pallete" checkbox for this specific cases. Or we can detect automatically if palette used by multiply textures and create own palette in such cases. In any case functionality which adds new information to wad files can break game, because every wad file have heap size limitation. And if unpacked (by game engine) wad file will be over this heap size game will crash.

mogaika commented 4 years ago

@leonifc331 download new version and when replacing one of the TXR_maiF0* textures, try to use new "Create new palette for replaced texture" checkbox. With this checkbox gow-browser will create new PAL_MAI01F resource specifically for texture you replacing. This should solve palette conflict. Be aware that you do not need to use this checkbox after you used it once. On screenshot below PAL_MAI01F0 - newly created palette. image

leonifc331 commented 4 years ago

amazing, you seem to have made it work :o but for me here did not appear this new check box :( image

mogaika commented 4 years ago

amazing, you seem to have made it work :o but for me here did not appear this new check box :( image

Oh, forgot to merge pull request #6 Please check again

leonifc331 commented 4 years ago

thank you so much, its work! image