search

moggieuk / ERCF-Software-V3

New software driver for ERCF control under Klipper
GNU General Public License v3.0
298 stars 63 forks source link

Suppress manual filament actions while printer is printing (or endless spool is in affect) #39

Closed ningpj closed 1 year ago

ningpj commented 1 year ago

I randomly hit eject (macro button) during a print and it unexpectedly ejected the filament. I assumed filament actions would be rejected if the printer wasn't paused, in an error state or had just been unlocked and wasnt expecting it to interrupt the print to do so. It was stupid but might be a valid edge case not envisioned....it might also be operating as intended ;-). If so, please close the issue.

HH v1.2.3-11-g4d3383f Klipper v0.11.0-86-g6026a99a

ningj#6911

moggieuk commented 1 year ago

Hi Nigel, thanks for the note, but this isn't possible (well reliable). The problem is that the commands like CHANGE_TOOL are run by the print itself. Then is nothing in Klipper that allows for distinguishing between a command issued by the GCODE of the print or the user. You could have two parallel commands sets but that would be clumsy.

Note that my new KlipperScreen support does do this in the UI... If I ever get round to a Mainsail version it will also have the same protection.

moggieuk commented 1 year ago

I'm going to close this as "not planned" because although good in concept, it's not possible to implement.