This tries to apply a per gate rotational distance.
Currently it uses the calibrated gate ratio to calculate the rotational distance for each gate, and it assumes that the rotational_distance configured on the manual_gear_stepper is for gate 0 (which seems to be the default assumption for ERCF software all along).
If there's no gate selected or unsyncing, it defaults to the the rotational distance for gate 0.
Personally, I don't think this solution is robust enough -- we probably want to give users the ability to configure gate rotational distances manually in their config. Though, they can already set the rotational distances per gate at runtime using the SET_EXTRUDER_ROTATION_DISTANCE command.
Further, my understanding is that without syncing ERCF also doesn't change the gear stepper's rotational distance -- if that's correct, maybe we should consider an alternative implementation where we do change the rotational distance, instead of relying a custom calibration logic.
This tries to apply a per gate rotational distance.
Currently it uses the calibrated gate ratio to calculate the rotational distance for each gate, and it assumes that the
rotational_distance
configured on themanual_gear_stepper
is for gate 0 (which seems to be the default assumption for ERCF software all along).If there's no gate selected or unsyncing, it defaults to the the rotational distance for gate 0.
Personally, I don't think this solution is robust enough -- we probably want to give users the ability to configure gate rotational distances manually in their config. Though, they can already set the rotational distances per gate at runtime using the
SET_EXTRUDER_ROTATION_DISTANCE
command.Further, my understanding is that without syncing ERCF also doesn't change the gear stepper's rotational distance -- if that's correct, maybe we should consider an alternative implementation where we do change the rotational distance, instead of relying a custom calibration logic.