search

moggieuk / ERCF-Software-V3

New software driver for ERCF control under Klipper
GNU General Public License v3.0
298 stars 63 forks source link

False trigger of "gate empty" #93

Closed ssackett closed 1 year ago

ssackett commented 1 year ago

I had a filament break on a particular gate and fixed it. After restarting the print the next time that gate was accessed I received a message that the gate was empty. The gate was not automatically tested before the "gate empty" message was issued. I manually executed the "gate test" macro and that fixed the problem.

moggieuk commented 1 year ago

Well, this is by design (I tend to check all used gates before the print using my prusaslicer PR and passing list of gates to "CHECK_GATES", but I guess it does make some sense to automatically perform the gate check -- I'll add that to my TODO list..

moggieuk commented 1 year ago

Hi, I've thought about this some more and I don't think it is right to retry.... There is a gate "unknown" state where an attempt will be made to load. Once Happy Hare has concluded the gate is empty, if the user changes that fact, then ERCF_CHECK_GATES GATE=xxx should be run. OR better still, the new filament is loaded with ERCF_PRELOAD GATE=x which will also update state.

Note that ERCF is now MMU with Happy Hare v2.

Based on this I'm going to close this issue. Please re-open if you see errors in my logic.

ssackett commented 1 year ago

Moggieuk,

I agree with your conclusion. Since I intervened in the operation of the software it should be my responsibility to inform the software about what I did.

Steve

On Sep 4, 2023, at 2:25 AM, moggieuk @.***> wrote:

Hi, I've thought about this some more and I don't think it is right to retry.... There is a gate "unknown" state where an attempt will be made to load. Once Happy Hare has concluded the gate is empty, if the user changes that fact, then ERCF_CHECK_GATES GATE=xxx should be run. OR better still, the new filament is loaded with ERCF_PRELOAD GATE=x which will also update state.

Note that ERCF is now MMU with Happy Hare v2.

Based on this I'm going to close this issue. Please re-open if you see errors in my logic.

— Reply to this email directly, view it on GitHub https://github.com/moggieuk/ERCF-Software-V3/issues/93#issuecomment-1704681902, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4EQIKFHGXNQTOVNRJ3NHTXYVX3ZANCNFSM6AAAAAA3U6SEDA. You are receiving this because you authored the thread.