search

moggieuk / Happy-Hare

MMU software driver for Klipper (ERCF, Tradrack, Prusa)
GNU General Public License v3.0
395 stars 94 forks source link

MMU_TEST_CONFIG does not allow changing bowden length variable #322

Closed hadesz closed 1 week ago

hadesz commented 1 week ago

Due to inconsistent naming, MMU_TEST_CONFIG identifies MMU_CALIBRATION_BOWDEN_LENGTH as invalid parameter, blocking users to fine-tune bowden length parameter.

(Pull req with a fix is incoming...)

moggieuk commented 1 week ago

Good catch. This was due to an additon to try to spot and give feedback for invalid parameters.

moggieuk commented 1 week ago

Thanks for the PR. This is the one naming exception. I was tempted to change the variable name but I think your PR is good for now.

hadesz commented 1 week ago

I did also consider that option, even the argument rename to match convention of the rest, but due to the lack of tests, I chose the least risky option...

On Wed, 26 Jun 2024, 12:36 moggieuk, @.***> wrote:

Thanks for the PR. This is the one naming exception. I was tempted to change the variable name but I think your PR is good for now.

— Reply to this email directly, view it on GitHub https://github.com/moggieuk/Happy-Hare/issues/322#issuecomment-2191367223, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACO3WZH72CXKMW7GPNIARLZJKKSXAVCNFSM6AAAAABJYFTR3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJRGM3DOMRSGM . You are receiving this because you authored the thread.Message ID: @.***>