moggieuk / Happy-Hare

MMU software driver for Klipper (ERCF, Tradrack, Prusa)
GNU General Public License v3.0
459 stars 115 forks source link

Bloblifier with Skew_correction #334

Open Dragi2k opened 2 months ago

Dragi2k commented 2 months ago

if you use a skew_correction it is possible that the Printer runs in "Move out of range" and the print starts with max part fan und no prime Thats becouse Bloblifyer uses Max Y but with skew_correktion it is Possible that it tries to move to y+0.15 or something

thats why {% set position_y = printer.configfile.config["stepper_y"]["position_max"]|float %} should be changed to {% set position_y = (printer.configfile.config["stepper_y"]["position_max"]|float-1) %}

moggieuk commented 2 months ago

Thank you. Agree this is an oversight.

@Dendrowen any change you can address? I suspect there is a way to ask klipper for the max position less skew to minimize the reduction in y position (although that would imply telling klipper the z-height). Maybe there is a max_skew variable?

Dendrowen commented 2 months ago

To gather the skew it seems I'd need to overwrite the gcode macro and save the skew myself and somehow calculate the max y position. Possible of course, but it will take some time and tinkering. I could set something up. Would you be willing to test it, @Dragi2k? I don't have skew correction set up and haven't encountered issues so far, so won't be doing it.

Dragi2k commented 2 months ago

yea i can test it but would it not be simpler to say {% set position_y = (printer.configfile.config["stepper_y"]["position_max"]|float-{blob_skew_value} %} and than create a value in the config example 1 i mean 1 mm from the back shoult be fine or not ? or is it possible to ask klipper if skew is enable and that on this case 1mm or 0,5mm from max y deducted

Dendrowen commented 2 months ago

Might be a quick workaround. I've added this and pushed it to my personal fork so you can test it. There are some other small updates in it too. https://github.com/Dendrowen/Happy-Hare

cd ~
git clone https://github.com/Dendrowen/Happy-Hare Happy-Hare-Dendrowen
cd Happy-Hare-Denrowen
./install.sh