moggieuk / Happy-Hare

MMU software driver for Klipper (ERCF, Tradrack, Prusa)
GNU General Public License v3.0
447 stars 107 forks source link

bug Missing [manual_mh_stepper selector_stepper] section in mmu_hardware.cfg #5

Closed danorder closed 1 year ago

danorder commented 1 year ago

current files don't seem to be able to find the [manual_mh_stepper selector_stepper] header filled in or clean off github.

moggieuk commented 1 year ago

Can you give me some more details? Does Klipper say "manual_mh_stepper" is an unknown section? If so then it would be because the installer hasn't been run and all the Klipper "extra" python modules have not been installed.

danorder commented 1 year ago

Sure using the installer the required files appear to load on under extras / uninstall the ercf version. everything goes accordingly up until it claims the header isn't there. this would be be using your included file and, using the mellow ercf board pins. (i think its the same as the fystec) and, for the sake of assurance yes the printer.cfg had the includes.. so im not certain why its having issues with that header. the file is seen since i can get errors on other settings before it reaches that point. i can provide the log if required but the error i seen was essentially the same.. sorry in advance for delayed response i just seen the notification in email.

Fragmon commented 1 year ago

i have the same with the combination with the klippain config. https://github.com/Frix-x/klippain/tree/new-ercf_HHv2

image image

Maybe there is a override of the stepper name image

Frix-x commented 1 year ago

@benoitone since it's your work in Klippain, can you have a look if something is wrong ? Is the branch in a working state ?

Benoitone commented 1 year ago

@Benoitone since it's your work in Klippain, can you have a look if something is wrong ? Is the branch in a working state ?

The branch is in working state for me... but only for the LGX Heavy extruder... for others extruders maybe thing about a different way to define them in klippain?

@Fragmon can you open an issue in Klippain repo for this? and post your printer.cfg?

danorder commented 1 year ago

To add im just using a regular klipper /mainsailos build with hand defined pins in the hardware.cfg. so general extruder values like the stable branch. Im not using a lgx deffs. Namely im interested in the new stallguard related setting here. and, adding a degree of support for the v400. This could be ideal with certain tested builds with original extruder.

moggieuk commented 1 year ago

Hi all, what's the state of this? Is it just an interaction issue with Klippain? Everything validates for me in my testing.

(sorry for delay -- just got back from summer holiday)

Fragmon commented 1 year ago

The problem is solved on the happy hare branch from @Benoitone

moggieuk commented 1 year ago

Thanks. So can I close this issue? Or is there something I should look at? (sorry, still a little confused)

Benoitone commented 1 year ago

Hello, yes the problem is with the include in printer.cfg. In klippain the mcu definition and Happy Hare files are already includes. So with klippain at the end of HH install script you must choose to do not include all the MMU config files.

Maybe if it was possible to check if klippain is the config and if this is the case omit to include the files in printer.cfg?

moggieuk commented 1 year ago

I can do that. Can you give me a reliable thing to check for? I.e. can you send your printer.cfg (or part of it) so I can see what to look for...

Benoitone commented 1 year ago

Maybe use this line to do not include the config files by your install script:

### Klippain is designed to be used with the MMU/ERCF Happy Hare software: https://github.com/moggieuk/Happy-Hare

Or this chain of characters: [include config/hardware/mmu.cfg]

moggieuk commented 1 year ago

Perfect. Thanks. I think [include config/hardware.mmu.cfg] is probably the most reliable since folks could edit/remove comments..

moggieuk commented 1 year ago

Ok. Detection of existing Klippain installation is now in the installer so config files will not be automatically inserted. Closing this issue.

Frix-x commented 1 year ago

Oh this is pretty cool ! Thanks for this addition to your install script :)