search

mogol / flutter_secure_storage

A Flutter plugin to store data in secure storage
https://pub.dartlang.org/packages/flutter_secure_storage
BSD 3-Clause "New" or "Revised" License
1.09k stars 340 forks source link

Add melos to project #681

Closed ThexXTURBOXx closed 1 month ago

ThexXTURBOXx commented 4 months ago

Using melos makes it much easier to manage multi-module repos such as this. In order to set everything up, run melos bootstrap in the root directory of this repo and the pubspec_overrides.yaml will automatically be generated. Publishing new package versions is as easy as running melos publish --no-dry-run (without --no-dry-run it does just a dry run to see if publishing would go smoothly). You might consider migrating to melos as it will also make your CI much more easy.

If you want me to complete this PR, just let me know and I will properly migrate the CI also.

juliansteenbakker commented 1 month ago

@ThexXTURBOXx This looks promising! I would be happy to integrate this. If its possible for you to complete the PR that would be great.

ThexXTURBOXx commented 1 month ago

@juliansteenbakker Thank you very much for your feedback! I have also migrated the CI and added some documentation about how to set up melos on a local machine - it is very quick to get it running. I have not tested the CI yet - so there could be some issues. However, as soon as you allow the workflows to run on this PR, we will see if everything works properly!

ThexXTURBOXx commented 1 month ago

@juliansteenbakker Sorry, forgot to add the right paths to the $PATH. Now, it should work :)

ThexXTURBOXx commented 1 month ago

I am terribly sorry, I had another typo in the commands - now it should really work

ThexXTURBOXx commented 1 month ago

Perfect, now it worked fine! F:\_Coding\flutter_secure_storage\flutter_secure_storage_windows\test\unit_test.dart actually had bad formatting - so I fixed it. Now the formatting check will also pass. This PR is now ready to get merged! :)

ThexXTURBOXx commented 1 month ago

By the way: flutter drive has problems: https://github.com/mogol/flutter_secure_storage/actions/runs/8983183839/job/24672407474?pr=681#step:7:79

According to this SO, you probably need to wait for the GitHub-hosted ARM64 runners. Or is it maybe enough to just specify arch: arm64 or something? Anyway, this is out of the scope of this PR, I would say... So, yes, feel free to merge this :)

vicenterusso commented 1 month ago

By the way: flutter drive has problems: https://github.com/mogol/flutter_secure_storage/actions/runs/8983183839/job/24672407474?pr=681#step:7:79

According to this SO, you probably need to wait for the GitHub-hosted ARM64 runners. Or is it maybe enough to just specify arch: arm64 or something? Anyway, this is out of the scope of this PR, I would say... So, yes, feel free to merge this :)

Isar was using macos runners for android integration tests. I changed to ubuntu-latest without problems. Maybe this could be done too?

juliansteenbakker commented 1 month ago

I have fixed this issue already on another branch, and will update this asap.

ThexXTURBOXx commented 1 month ago

@juliansteenbakker I merged upstream develop again into my branch and also added a workaround for the flakiness of the flutter drive integration test(s). It is not non-flaky now, but the chances that the tests now fail are extremely low, so it should be fine :)