search

mogrifier / WavsynModular

WavsynModular code for VCVRack Modules
GNU General Public License v3.0
1 stars 0 forks source link

look at why space adjustment is changing presets #47

Closed mogrifier closed 3 months ago

mogrifier commented 3 months ago

I think the space values in my presets add up to less than 1, whoever, I see movement when loading some. Investigate the preset data and the algorithm that adjusts space params.

mogrifier commented 3 months ago

I think new json is loaded in via a separate thread. As the UI changes, it triggers my code to adjust the space parameters to keep them below 1 in total. This causes all kids of changes in the values. They don't simply load at once due to thread race.

mogrifier commented 3 months ago

confirmed by commenting out the space adjustment/checking code. Presets now load perfectly. If I only knew when a preset was loading (such as a flag to check) I could skip that code and only enforce other times. Do I need the code???? What happens if you exceed 1 for total space? I think it just quits playing after that.

mogrifier commented 3 months ago

Without space checking, it still plays whole pattern but now it may be greater or less than 1 bar. Interesting freedom. Could keep as % of 1 bar, but if you make a pattern using 300%, it is now three bars long. This is an interesting and simpler approach, plus presets load. I think maybe a hybrid approach- free and lock settings on a 2-way switch. Presets would only load right if in free mode. in lock mode, it would enforce 100% size.

mogrifier commented 3 months ago

adding issue to implement free/lock mode. changing mode switch to QUANT.