search

mogsdad / SheetConverter

Google Apps Script library - interprets Google Sheets Formats, converts to formatted text or html
49 stars 26 forks source link

V8 support #15

Closed abkarino closed 4 years ago

abkarino commented 4 years ago

https://github.com/mogsdad/SheetConverter/blob/master/SheetConverter/Code.gs#L58 class keyword is reserved, you should rename it.

aminco-edw commented 4 years ago

Yes, please fix. This kicks up an error with GAS V8 turned on.

sai-creator commented 4 years ago

The error I am getting is "SyntaxError: Unexpected token class (line 57, file "Code", project "SheetConverter")".

So I have disabled Chrome V8 for now. Kindly make required changes in the code.

jmklee commented 4 years ago

The error I am getting is "SyntaxError: Unexpected token class (line 57, file "Code", project "SheetConverter")".

So I have disabled Chrome V8 for now. Kindly make required changes in the code.

That happen to me what should i do?

sai-creator commented 4 years ago

The error I am getting is "SyntaxError: Unexpected token class (line 57, file "Code", project "SheetConverter")". So I have disabled Chrome V8 for now. Kindly make required changes in the code.

That happen to me what should i do?

I disabled Chrome V8 and it worked fine.

mogsdad commented 4 years ago

https://github.com/mogsdad/SheetConverter/pull/16

j6274 commented 4 years ago

was this update made? I am still getting this error message. or please advise how to disable Chrome V8. Thanks!