mogsie / scxmlgui

Automatically exported from code.google.com/p/scxmlgui
0 stars 0 forks source link

Display edge condition on the SCXML graph #28

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

Currently the graph only shows the event names on the outgoing arch. 

What is the expected output? What do you see instead?

It would be nice to include the conditions as well

What version of the product are you using? On what operating system?
latest subversion r137

Please provide any additional information below.

I attached a patch file, containing a proposed change against svn r137.
It simply changes the convertValueToString method to include the condition for 
an event and adds some layouting information to the SCXMLEdge class

Original issue reported on code.google.com by jkirschn...@gmail.com on 27 Sep 2011 at 12:55

Attachments:

GoogleCodeExporter commented 9 years ago
i didn't display conditions by default because they can easily be very long 
cluttering the graph.

1) how about adding a config flag somewhere to enable/disable the display of 
additional information on edges (potentially, one would like to decide exactly 
what to display for an edge or a node)?

2) another option (less efficient) would be to truncate the condition if it's 
longer than a certain value and maybe leave the complete display of the 
condition to the ALT overlay that appears when standing still on the edge for a 
few seconds.

for now i prefer to leave out the display of conditions and leave it to the ALT 
overlay (if one really needs to look at them), at least until i (or someone 
else) can implement something better like option 1 above.

anyway, thanks for submitting this patch.

Original comment by fmorbini on 29 Sep 2011 at 12:52

GoogleCodeExporter commented 9 years ago

Original comment by fmorbini on 29 Sep 2011 at 12:54

GoogleCodeExporter commented 9 years ago
Hi,

thanks for your response.
I agree that it would probably clutter the graph to much, if one has very 
complex conditions. On the other hand, I find it quite useful to see what's 
going on just by inspecting the graph.

So I would be in favour of having an additional flag somewhere which would 
display the conditions (maybe capped if too long) as well, maybe this could be 
part of the overall layout structure in the scxml file as well, so persisted 
across re-openings

Original comment by jkirschn...@gmail.com on 29 Sep 2011 at 11:50