TropicalPenguin
commented
6 years ago Yo,
The develop branch already uses the list strategy :)
On Tue, Jan 9, 2018 at 6:09 AM, k-sok notifications@github.com wrote:
The resulting batch script is built by using string concatenation.
commands = 'BEGIN\n' commands += cmd1 commands += cmd2 ... commands += cmdN g.client.batch(commands)
The larger the entire script is (i.e. the commands string) the longer takes each concatenation operation (because of the underlying memory reallocation and copying).
A better approach is to use a list of strings and join it when committing.
commands = ['BEGIN'] commands.append(cmd1) commands.append(cmd2) ... commands.append(cmdN) g.client.batch('\n'.join(commands)
By implementing the above solution, I was able to improve the performance with large batches by magnitudes.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mogui/pyorient/issues/261, or mute the thread https://github.com/notifications/unsubscribe-auth/ALCuO92xxx4KSOErxmi1Yu8cN7RPbYIwks5tIkvegaJpZM4RWrE2 .
k-sok
The resulting batch script is built by using string concatenation.
The larger the entire script is (i.e. the commands string) the longer takes each concatenation operation (because of the underlying memory reallocation and copying).
A better approach is to use a list of strings and join it when committing.
By implementing the above solution, I was able to improve the performance with large batches by magnitudes.