mogumbo / rviz_lighting

RViz plugin that provides ambient, directional, point, and spot lights.
21 stars 16 forks source link

Default direction should be 1, 0, 0 #1

Open lucasw opened 7 years ago

lucasw commented 7 years ago

The light should point forward according to http://www.ros.org/reps/rep-0103.html x-forward convention (though an argument could be made for z-forward optical frame convention also).

If that were adopted, does there even need to be a Direction control at all? The user could be required to set up a tf to point where they want it. static_transform_publisher or https://github.com/lucasw/rviz_interactive_tf are convenient methods to generate frames.