search

mogutt / TTAndroidClient

The android client of mogutt
http://tt.mogu.io/
742 stars 283 forks source link

fix a bug in com.mogujie.tt.ui.activity.LoginActivity.java #74

Closed oldoldb closed 10 years ago

oldoldb commented 10 years ago

In previous version, if we just input username, then click "login" button with password empty, there will come out a toast showing "please input username". it is obviously not suitable.

I just add a string named "error_password_required" to show "please input password" in the above case.

In my version, to be frankly, if we leave both "username" and "password" empty, then click "login" button, there will come out "please input password". it is not that good, and we should change the logic here. it may need adjust the logic and i am not sure what you want, so leave it to you.

mgjkuaidao commented 10 years ago

Thanks a lot for your contribution,we have merge your code to master branch