search

moh-kenya / echis-2.0-integration

This Repo will be used for the Integration of echis,afya ke,client registry,KHIS integration and also any other future systems
2 stars 8 forks source link

Flag mismatching client details on eCHIS for CHP Follow up #117

Closed freddieptf closed 1 year ago

freddieptf commented 1 year ago

Upon submitting the same national ID with different names, the two clients get the same UPI. Ensure that the mismatching details are flagged for the CHP to follow up instead of updating with the UPI.

Issue from https://github.com/moh-kenya/config-echis-2.0/issues/1353

freddieptf commented 1 year ago

From our last discussion, we had talked about creating a report detailing what fields are wrong and then using a task on eCHIS to notify the CHP for follow up @karimkkanji @kitsao. Is this still the preferred approach?

karimkkanji commented 1 year ago

@freddieptf This is key: https://github.com/moh-kenya/echis-2.0-integration/pull/118#issuecomment-1750398991

freddieptf commented 1 year ago

@karimkkanji why shouldn't we include the phone number? The implementation doesn't stop anyone from reusing a phone number

karimkkanji commented 1 year ago

If a user was registered on an EMR, then they use a different number from the one they used in the EMR, it is not assigning the UPI. Users may decide to give a different phone number and it is still okay. Using one that is different from CR is allowed but in this case it fails.

On Fri, 6 Oct 2023 at 15:09, Fred @.***> wrote:

@karimkkanji https://github.com/karimkkanji why shouldn't we include the phone number? The implementation doesn't stop anyone from reusing a phone number

— Reply to this email directly, view it on GitHub https://github.com/moh-kenya/echis-2.0-integration/issues/117#issuecomment-1750532623, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEN7ZEI76OZMJQPJ4RFMZ2TX57YGNAVCNFSM6AAAAAA4XDKBYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJQGUZTENRSGM . You are receiving this because you were mentioned.Message ID: @.***>

karimkkanji commented 1 year ago

@freddieptf This is key:

https://github.com/moh-kenya/echis-2.0-integration/pull/118#issuecomment-1750398991

In this screenshot, the upi is not stored as it says phone number is mismatched. This is on the mediator implementation.

freddieptf commented 1 year ago

Thanks for pointing that out @karimkkanji, create a ticket and we can work on a fix for that