search

mohabusama / pyguacamole

Guacamole Python Client
MIT License
108 stars 34 forks source link

Add support for device display size overrides #15

Closed richlanc closed 3 years ago

richlanc commented 3 years ago

Guacd supports overriding the remote display width/height/dpi, but pyguacamole doesn't differentiate between the client display size and the remote display size.

In this PR we've provided the ability to override the remote display width/height/dpi.

We could it was necessary to override the remote dpi when handling HiDPI on the client-side.

mohabusama commented 3 years ago

Thanks for the PR.

I am curious on why the caller of the handshake wouldn't set the width, height and dpi to the override value(s) instead?

mohabusama commented 3 years ago

Released in v0.11

richlanc commented 3 years ago

I am curious on why the caller of the handshake wouldn't set the width, height and dpi to the override value(s) instead?

My argument is mostly for flexibility. Guacd separates the client width/height/dpi and the device width/height/dpi, so we should do the same, allowing for more options.