search

mohabusama / pyguacamole

Guacamole Python Client
MIT License
108 stars 34 forks source link

Implement connecting to existing session. #9

Closed paidem closed 5 years ago

paidem commented 5 years ago

Guacamole specs allow "selet" command to provide existing session id instead of protocol.

https://guacamole.apache.org/doc/gug/protocol-reference.html#select-instruction

ID The name of the protocol to use, such as "vnc" or "rdp", or the ID of the active connection to be joined, as returned via the ready instruction.

In my application I implemented reconnecting to existing session, which allows same session to be shared between several users (collaborating or specatator mode), I had to do this change to support it.

mohabusama commented 5 years ago

Thanks @paidem and sorry for the late review. Is it possible to update unit tests as well?

mohabusama commented 5 years ago

Thanks. Released in version 0.9

paidem commented 5 years ago

Hi. I mentioned you in https://guacozy.readthedocs.io/en/latest/development/kudos/ , your project was a great help in implementing Guacozy!

mohabusama commented 5 years ago

Awesome work :)