search

mohae / deepcopy

Deep copy things
MIT License
569 stars 122 forks source link

Fix deep-copying of type-aliased primitives #1

Closed atombender closed 8 years ago

atombender commented 8 years ago

This also adds some more tests.

atombender commented 8 years ago

Oops, I did not see the message about this repo being deprecated. Will take a look at the replacement.

mohae commented 8 years ago

Where does it say that it's deprecated so I can fix that message? It was...but then I rethought that decision and recently refactored this.

atombender commented 8 years ago

It was in the readme, which I see you've changed.

On Oct 2, 2016, at 19:40, Joel Scoble notifications@github.com wrote:

Where does it say that it's deprecated so I can fix that message? It was...but then I rethought that decision and recently refactored this.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

mohae commented 8 years ago

Oh, this was a while ago. Sorry I didn't notice this pull request sooner. I wasn't ignoring it, it was an oversight.

I don't think this applies with the updated version of deepcopy. I appreciate your attempt to contribute thought!

atombender commented 8 years ago

Does this mean that github.com/mohae/utilitybelt/deepcopy is the one that's deprecated now, and this is the main repo?

mohae commented 8 years ago

Yes. The current readme for that is:

This exists for legacy reasons so that anything that happens to use it will not break. See also deepcopy

Sorry for the confusion, but this package kept getting used, in spite of my deprecation note so I decided I should undeprecate it and clean up this repo and apply my fixes here.

Also the utilitybelt repo still has caveats in the README because of possibility that the stuff in there may change and/or may need additional testing and work.

I consider this one safe to use if one must use a generic deep copy function in Go. There will not be any further api changes to this package unless it is required by a bug fix.

atombender commented 8 years ago

Thanks for the clarification. I was using this repo first, then the other one. Back to this one, I guess!

mohae commented 8 years ago

Sorry! I promise I won't change it again.

atombender commented 8 years ago

No problem. I prefer top-level packages.