search

moham96 / service.subtitles.opensubtitles_by_opensubtitles

KODI OpenSubtitles.org addon modified by opensubtitles, works without login
https://forum.opensubtitles.org/viewtopic.php?f=8&p=36070
10 stars 5 forks source link

Kodi Matrix dependecy issues #1

Open pyro12 opened 3 years ago

pyro12 commented 3 years ago

Cannot be installed in kodi 19.x

peno64 commented 2 years ago

@pyro12 This is a very interesting addition to the opensubtitles addon. I would like to modify it for kodi 19 and if possible push it back to this repository. I already did this with other addons also. Are you still active @moham96 and would you accept a pull request with changes?

peno64 commented 2 years ago

@moham96 , @pyro12 , @jmh2002 The addon is in my repo: https://peno64.github.io/repository.peno64/ You can use this same repo for both kodi 18 and 19. You will find it under subtitles, OpenSubtitles.org by OpenSubtitles with dual subs. It automatically also installs the needed dependency pysubs2 so no need to bother for that. Note that dual subs is by default off with this version. You must go first to the settings of the addon and enable it. I not only modified it to work on kodi 19 (while still working on kodi 18) it has also some fixes, a better name (... with dual subs) and the latests changes of all clones that are out there of the original addon.

moham96 commented 2 years ago

Hi @peno64, Yes i am still active, i kinda lost interest in this addon because KODI developers refused to provide some sort of multi select api in the subtitles dialog.

I will happily merge your PRs but there needs to be nice commits with understandable commit messages and not just a pile of changes.

Regards

peno64 commented 2 years ago

I am afraid it is just a pile of changes. Although there are not so many.