mohamed-badaoui / asus-touchpad-numpad-driver

Activate Numpad inside the touchpad with top right corner switch
301 stars 70 forks source link

Added support for UX325EA (incl. install.sh) #53

Closed LIZARDRIVE closed 3 years ago

kawaegle commented 3 years ago

@LIZARDRIVE Can you please try to work the install with a new method (because when add a layout we don't want to write it any time) using ls

echo "Select models keypad layout:"
PS3='Please enter your choice '
options=($(ls numpad_layouts) "Quit")
select opt in "${options[@]}"
do
    opt=${opt::-3}
    case $opt in
        "m433ia")
            model=m433ia
            break ;;
        "ux433fa")
            model=ux433fa
            break;;
        "ux581l" )
            model=ux581l
            break;;
        "Quit")
            exit 0;;
        *)
            echo "invalid option $REPLY";;
    esac
done

it'll be easy after

mohamed-badaoui commented 3 years ago

Hi,

Thank you for this contribution. But it seems that there is no difference with the m433ia model? https://github.com/mohamed-badaoui/asus-touchpad-numpad-driver/blob/main/numpad_layouts/m433ia.py

I think there is no need to create a config file per model. Each configuration file must be used for a particular touchpad layout.