search

mohamed-helala / pmtk3

Automatically exported from code.google.com/p/pmtk3
MIT License
0 stars 0 forks source link

normalise function is not a part of pmtk, may be we have to use normalize one instead #32

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1.Some functionality that uses function
path = viterbi_path(prior, transmat, obslik)

What is the expected output? What do you see instead?

What version / revision of the product are you using? On what operating
system?
pmtk r2776

Please provide any additional information below.
Replace normalise function with normalize one on lines: 53, 64
http://code.google.com/p/pmtk3/source/browse/trunk/toolbox/LatentVariableModels/
hmm/sub/viterbi_path.m#53

Original issue reported on code.google.com by RA.Dragun on 28 Aug 2011 at 7:56

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
I also experienced this same problem. I don't know if there is a separate 
normalise.m file that is needed, or if changing these lines to "normalize" 
correctly solves the problem. What is more interesting is that this (possible) 
bug causes the testPmtk3 to fail:

??? Undefined function or method 'normalise' for input arguments of type 
'double'.

Error in ==> viterbi_path at 53
    [delta(:,t), n] = normalise(delta(:,t));

Error in ==> hmmMap at 22
path = viterbi_path(pi, A, exp(logB));

Error in ==> hmmDiscreteTest at 38
decodedFromTrueViterbi = hmmMap(trueModel, observed);

Error in ==> testPmtk3 at 68
hmmDiscreteTest;

Original comment by iamguinn...@gmail.com on 29 Jun 2012 at 9:54

GoogleCodeExporter commented 9 years ago 
Moved to GitHub: https://github.com/probml/pmtk3/issues/32

Original comment by irosen on 4 Jan 2014 at 2:35