Closed jw3126 closed 5 years ago
Merging #19 into master will increase coverage by
7.07%
. The diff coverage is88.88%
.
@@ Coverage Diff @@
## master #19 +/- ##
==========================================
+ Coverage 86.07% 93.15% +7.07%
==========================================
Files 1 1
Lines 79 73 -6
==========================================
Hits 68 68
+ Misses 11 5 -6
Impacted Files | Coverage Δ | |
---|---|---|
src/KissThreading.jl | 93.15% <88.88%> (+7.07%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2e8287f...19d603e. Read the comment docs.
Looks good to me, but I think the Manifest file is important since it is used in Travis tests. If a test fails on Travis, you are more likely to reproduce it locally when using the same Manifest.
I think its almost always bad practice to commit the Manifest.toml
. It pollutes the git diffs and makes installing multiple packages in a single environment hard.
and makes installing multiple packages in a single environment hard.
How is that?
I am not completly sure, but I think if you install a package that ships with a Manifest file then versions of its dependencies in the environment are constrained by the Manifest file?
Okay, I think that was superstition on my part, see also here for a list of pros and cons. So I can add the Manifest again.
then versions of its dependencies in the environment are constrained by the Manifest file?
No this is not the case.
Thanks for your understanding :)
Properly removing 0.6 support, which does not pass all tests anyway. Some other minor improvements.