search

mohamed82008 / KissThreading.jl

Simple patterns supporting working with threads in Julia
MIT License
37 stars 4 forks source link

Improve tests #5

Open bkamins opened 6 years ago

bkamins commented 6 years ago

What I think should be done with tests:

  1. separate logging of correctness tests (that can go to console) and performance tests (that I think we should use separate logger - best to save logs to a file so later it is simple to analyze the contents of the file).
  2. Improve test coverage - especially to check what is a good batch size for different types of single job size.
mohamed82008 commented 5 years ago

Is this issue blocking for registration?

bkamins commented 5 years ago

There is little benefit from registering a package (apart from minimally easier installation).

I am not actively maintaining this repository right now, so if you want to take it over I can transfer it to you (and then you can go ahead registering it etc.). Of course I would review PRs if some pushed them and asked for help.

CC @pszufe - maybe also you would want to get involved here more?

mohamed82008 commented 5 years ago

I am OK with not having it registered, and I don't mind taking ownership of the package either if you don't want to maintain it anymore. You probably know more about multithreading in general than I do though, so I would appreciate your PR reviews every now and then.

bkamins commented 5 years ago

It looks that in order to make a transfer you would have to delete your repository with the same name. Anyway - you have full write privileges to this repository and we can transfer it later. Thank you for your work.

mohamed82008 commented 5 years ago

FWIW, I deleted my repo in case you are still interested in transferring ownership. Sorry it took me a while to get to this!

bkamins commented 5 years ago

OK - I have sent a transfer request.

mohamed82008 commented 5 years ago

Awesome, thanks!