search

mohamedmansour / my-hangouts-extension

My Hangouts for Google Plus Chrome Extension
https://plus.google.com/116935358560979346551/about
Other
35 stars 9 forks source link

Endless "loading..." when 0 hangouts #113

Closed duckinator closed 5 years ago

duckinator commented 12 years ago

When there are no hangouts at all listed there (I restricted it to my circles only), it says "loading..." forever. Perhaps "No hangouts are currently active." or similar, instead?

mohamedmansour commented 12 years ago

We would need a better error description, or perhaps a better way to know when we are loading hmm. The thing is that when I do (/js/popup_controller.js#L81), I always show "loading..." when we have no hangouts. It should be smarter.

duckinator commented 12 years ago

I don't particularly understand that code (and I'm a bit busy fighting with porting a compiler to new OSes to read it thoroughly ;P) , but does the API (which, iirc is fake and you ended up having to hack one together...) return anything when there's no results? Even just an empty string?

mohamedmansour commented 12 years ago

Google returns an empty result when there is an error and when there are no results. I would need to do more discovery to differentiate between those two. I will see what I can do when I have time, I am still in moving (finding a home) stage :(

duckinator commented 12 years ago

It's alright. No major rush, just wanted to leave an issue here because I thought it was a bit silly. :P

Good luck with the move!