mohamedmansour / my-hangouts-extension

My Hangouts for Google Plus Chrome Extension
https://plus.google.com/116935358560979346551/about
Other
35 stars 9 forks source link

Updated notification badge #34

Closed marmat closed 12 years ago

marmat commented 12 years ago

\ DO NOT MERGE THIS YET; I ACCIDENTALLY GOT AN OLDER VERSION OF THE BACKGROUND_CONTROLLER **

I changed the looks of the notification badge a bit so that it looks like the original Google+ notification badge (i.e. rounded corners and a stroke around them, see images for comparison). Furthermore I made the badge being rendered as inactive whenever the count is a non-positive number (if this is not desired, make sure to set newItem to false when calling the method with a count of zero, I didn't look where the method gets called).

Please see the comments in my commit; maybe the method for drawing a rounded rectangle should be added to the Canvas context prototype somewhere else.

Active Badges

Inactive Badges

mohamedmansour commented 12 years ago

Heya martin, this is great! Beyond awesome, very good job! Exactly what i am looking for!

Some comments.