search

mohamedmansour / my-hangouts-extension

My Hangouts for Google Plus Chrome Extension
https://plus.google.com/116935358560979346551/about
Other
35 stars 9 forks source link

Maps API error message #94

Closed kimbeasley closed 12 years ago

kimbeasley commented 12 years ago

I just received a message that the Maps API has been disabled for this extension due to TOS violations. Here's the screenshot: http://screencast.com/t/Ikxob86oV

marmat commented 12 years ago

I can confirm that. Interestingly, this happens only in the Webstore Version (4.2.0). The Maps tab is still working in the Git Version (4.3.0).

Does anybody see what part of the TOS are meant by that message?

mohamedmansour commented 12 years ago

This is so weird :( I am really disappointed in what is happening now, we are following the limits and we are caching all the locations. / @kimbeasley @kaktus621

mohamedmansour commented 12 years ago

@kimbeasley @kaktus621 @johnbc should we just publicly go out with this?

marmat commented 12 years ago

Quote by Thor Mitchell: "It appears to load the API once, and then send the same geocoding requests repeatedly thousands of times (literally)." (source)

Let's find that evil bug, shall we? ;-)

mohamedmansour commented 12 years ago

I think he is referring to all the 7000 people installing this extension when a new participant joined, all 7000 are doing the geocoding request. I think we should (As martin said) use database caching, so you don't request anymore in the future. And perhaps lazy loading, only do queries when visiting maps tab.

kimbeasley commented 12 years ago

YEAH! I hope the database caching fixes everything.

mohamedmansour commented 12 years ago

This change adds webStorage to the results for locations. Hope that makes Google happy

kimbeasley commented 12 years ago

The error stopped.

mohamedmansour commented 12 years ago

@kimbeasley The error never happened on the dev version since the extension ID differed, it only happened when we deploy it to the user. Someone is misusing our extension API and somehow intentionally causing these disruptions :(

kimbeasley commented 12 years ago

Wow, can you figure out who?

mohamedmansour commented 12 years ago

@kimbeasley only Google can :<