mohamedmansour / prayer-times-extension

Under Development: Prayer Time Calculation based on Geolocation for Chromium and Firefox
https://chrome.google.com/webstore/detail/ndmbeogingkjkmmkoomnigifmpajmbkc
64 stars 23 forks source link

Translation mistake in french version #11

Closed targeex closed 6 years ago

targeex commented 12 years ago

Dhur is translated "coucher du soleil" wich mean sunset

Logicbloke commented 12 years ago

I confirm there is a mistake on that one.

mohamedmansour commented 6 years ago

@targeex @Logicbloke what is the correct translation?

Does this make sense?

    "fajr": {
        "message": "L'aube"
    },
    "sunrise": {
        "message": "Lever du soleil"
    },
    "dhuhr": {
        "message": "Crépuscule"
    },
    "asr": {
        "message": "Asr"
    },
    "sunset": {
        "message": "Coucher du soleil"
    },
    "maghrib": {
        "message": "Maghrib"
    },
    "isha": {
        "message": "Isha"
    },
    "midnight": {
        "message": "Minuit"
    },
Logicbloke commented 6 years ago

I think we should just keep Fajr, Duhr and Asr as is.

Sent from my iPhone

On Jul 1, 2018, at 8:11 PM, Mohamed Mansour notifications@github.com wrote:

@targeex @Logicbloke what is the correct translation?

Does this make sense?

"fajr": { "message": "L'aube" }, "sunrise": { "message": "Lever du soleil" }, "dhuhr": { "message": "Crépuscule" }, "asr": { "message": "Asr" }, "sunset": { "message": "Coucher du soleil" }, "maghrib": { "message": "Maghrib" }, "isha": { "message": "Isha" }, "midnight": { "message": "Minuit" }, — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

mohamedmansour commented 6 years ago

@logicbloke thank you, I just did that!

mohamedmansour commented 6 years ago

@Logicbloke @targeex the extension is updated , y ou can download it from here https://chrome.google.com/webstore/detail/ndmbeogingkjkmmkoomnigifmpajmbkc