Updated the structure for Chrome 67+ support

[msdousti]

Chrome 67+ only supports a manifest_version of 2 (reference). So, many older extensions fail to load.

I updated the manifest_version, and adapted the background to the new version.

However, the new security settings of Chrome 67+ prevented any inline JavaScript. So, I had to tinker with the HTML pages, and transfer all instances of inline JavaScript to separate *.js files. Furthermore, I had to set content_security_policy in the manifest file for proper handling of Google Maps JavaScript files.

[mohamedmansour]

Thank you 🙏🏻 will try to push this to the store tomorrow morning inshallah! I’ll see what I can do to refresh this extension too, it’s 7+ years old :-)

[msdousti]

You're most welcome! I've been using it like, forever, and I've missed it already! Even though I had absolutely no knowledge of how Chrome extensions work, I took the liberty of reading the code, and tried my best to make it work again. Please feel free to change it in anyway you see apt, as I might have messed up with things unknowingly.

May God be with you, and thanks a lot for this valuable extension!

[mohamedmansour]

@msdousti thanks for all the work, I fixed a few more bugs from the conversion ( https://github.com/mohamedmansour/prayer-times-extension/commit/ca2eab9473cb2ed69bdb5fcd49b60b75192d7e65 https://github.com/mohamedmansour/prayer-times-extension/commit/a9a7c0080e99b3843e99e8bfd209480ae4b8b7ed https://github.com/mohamedmansour/prayer-times-extension/commit/92aaa8c862cef758d2998402ac9f58e38ea4a7c0 https://github.com/mohamedmansour/prayer-times-extension/commit/961774ae664e42b52ecbba91d7e1f5a62b14e849 https://github.com/mohamedmansour/prayer-times-extension/commit/e57ea6f6f9062c32871cc4488e8c4f49a2095162 https://github.com/mohamedmansour/prayer-times-extension/commit/95254ceff31eaa260e74296cc5a9c2092e8a78f1 https://github.com/mohamedmansour/prayer-times-extension/commit/7c63be06b51fef71d5bf02698af1068943e26a2c https://github.com/mohamedmansour/prayer-times-extension/commit/aa879f6ae0c46bf1b00e821828cb9bf2d366ada7 ) and i deployed a new version here: https://chrome.google.com/webstore/detail/ndmbeogingkjkmmkoomnigifmpajmbkc

If you can help me test it, that would be awesome.

Going forward, I will figure out a way to use WebPack instead.

[msdousti]

Thanks for all the great work!

I think two great features which you might consider are as follows:

• Making the extension non-persistent, by setting "persistent": false in manifest.json: https://github.com/mohamedmansour/prayer-times-extension/blob/aa879f6ae0c46bf1b00e821828cb9bf2d366ada7/manifest.json#L13 Non-persistent extensions do not always run in the background, and do not take the system resources all the time. The catch, however, is that they should follow an event-driven model. For Prayer Times, I think the only important event is the time change: It should wake up every minute, update the timestamp on its icon, show a notification if needed, and go back to sleep.
• I recall from old times that Prayer Times didn't respond to system time changes: For instance, when a user changes the system time, Prayer Times will continue to use the old time until the browser is restarted. Other examples include when the system time changes due to observing daylight saving, or when the computer comes back from the sleep/hibernate while the browser was open.

If you like, I can open separate issues for the above.

[mohamedmansour]

Thank you, opened up #21 and #22