Regression - Clicking Notifications don't mute athan

mohamedmansour / prayer-times-extension

Under Development: Prayer Time Calculation based on Geolocation for Chromium and Firefox

https://chrome.google.com/webstore/detail/ndmbeogingkjkmmkoomnigifmpajmbkc

64 stars 23 forks source link

Regression - Clicking Notifications don't mute athan #23

Closed mohamedmansour closed 5 years ago

mohamedmansour commented 5 years ago

From support on extension site:

Is there a way to add a mute option for the athan? During a office meeting call, athan started and I cannot stop it from playing and it interrupts the meeting. Please help with this feature.

Noticed Google removed browser notifications and went to OS notification (which is great), but somehow the click event stopped working.

Two tasks:

[ ] Once notification is handled, it should stop playing the athan.
[ ] Add a context menu to quickly mute notification.

mohamedmansour commented 5 years ago

Note: this is the commit where I added it in the old notification UX 1d39903d294d62df027bdb9134a42e1f4355f646 most likely new API https://developer.chrome.com/extensions/notifications#event-onClicked