mohamedmansour / reload-all-tabs-extension

Reload All Tabs Google Chrome Extension
https://chrome.google.com/extensions/detail/midkcinmplflbiflboepnahkboeonkam
81 stars 23 forks source link

Reduce permissions granted to extension #16

Closed triplepoint closed 6 years ago

triplepoint commented 6 years ago

Reduce the permissions given to this extension so that instead of: Read and change all your data on the websites you visit

The extension asks for: Read your browsing history

This appears to be the best we can do, given that the extension needs the "tabs" permission in order to reload tabs.

mohamedmansour commented 6 years ago

@triplepoint does keyboard shortcuts work? Last I checked permissions (8 years ago) it was very messed up

mohamedmansour commented 6 years ago

I believe to fix this, and remove these permissions, we need to implement commands instead of a content script, like the following: https://developer.chrome.com/extensions/commands back then we didn't have this

triplepoint commented 6 years ago

I tested the keyboard shortcut before I submitted the PR, it looked good to me on macos.

On Sat, Jul 28, 2018, 23:10 Mohamed Mansour notifications@github.com wrote:

I believe to fix this, and remove these permissions, we need to implement commands instead of a content script, like the following: https://developer.chrome.com/extensions/commands

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mohamedmansour/reload-all-tabs-extension/pull/16#issuecomment-408654589, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQ-G09--BbxDJoVepK_F63BGF6bxbVMks5uLVHHgaJpZM4VlMg9 .

mohamedmansour commented 6 years ago

@triplepoint I just checked, it didn't load the content script. What you noticed was the default refresh in Chrome. You can right click on any webpage, and open the inspector to see if the content script was loaded.

image

The reason it didn't load is because the protocols were removed in the manifest permission. Let me see if I can convert it to input manager.