search

mohamedmansour / reload-all-tabs-extension

Reload All Tabs Google Chrome Extension
https://chrome.google.com/extensions/detail/midkcinmplflbiflboepnahkboeonkam
80 stars 23 forks source link

Remove content script in favor of Commands #17

Closed mohamedmansour closed 6 years ago

mohamedmansour commented 6 years ago

In order to remove more permissions, and keep supporting keyboard events, we need to remove content scripts and user keyboard events. As explained in this PR #16

This means keyboard events will not be customizable anymore. I believe this would be a decent drawback to protect to enhance security.

https://developer.chrome.com/extensions/commands

We could use Ctrl+Shift+R (Command + Shift +R on mac)

mohamedmansour commented 6 years ago

The user is free to designate any shortcut as global using the UI in chrome://extensions \ Keyboard Shortcuts, but the extension developer is limited to specifying only Ctrl+Shift+[0..9] as global shortcuts.

Sweet! This will totally work!

mohamedmansour commented 6 years ago

@triplepoint can you test if your mac works for this setup? (Reload all tabs in the window via keyboard)

triplepoint commented 6 years ago

With commit 3aa5ab installed, I can Alt + Shift + r to reload all tabs. The context menu has a "Reload this window" option that also reloads all tabs. The extension button in the URL bar also reloads all tabs.

mohamedmansour commented 6 years ago

Thank you 🙏Will submit v4.2 to app store!