mohamedmansour / reload-all-tabs-extension

Reload All Tabs Google Chrome Extension
https://chrome.google.com/extensions/detail/midkcinmplflbiflboepnahkboeonkam
80 stars 23 forks source link

Allow custom reload action for Browser Action #20

Closed mohamedmansour closed 3 years ago

mohamedmansour commented 5 years ago

Currently the reload strategy of the browser action is either all windows or current window. It would be nice to extend it so the user can customize it.

/**
 * Reload Routine. It checks which option the user has allowed (All windows, or
 * or just the current window) then initiates the request.
 */
ReloadController.prototype.reload = function(info, tab)
{
  if (this.cachedSettings.reloadAllWindows) { // All Windows.
    this.reloadAllWindows()
  }
  else { // Current Window.
    chrome.windows.getCurrent(this.reloadWindow.bind(this))
  }
}
mohamedmansour commented 5 years ago

Actually, its a bug, reloadAllWindows doesn't pass the options

mohamedmansour commented 3 years ago

This is implemented in #32 !