search

mohamedsabil83 / filament-forms-tinyeditor

A TinyMce Editor component for filament
MIT License
164 stars 37 forks source link

Added $previewMaxHeight() and $previewMinHeight() to the disabled view #112

Closed poldixd closed 7 months ago

poldixd commented 7 months ago

I added max-height and min-height to the disabled view. For the scrolling I also added the css class overflow-y-auto to the div element.

mohamedsabil83 commented 7 months ago

Thanks, @poldixd, for this contribution. It's better to make it enabled by a function or configuration. That way, every dev can display it like now or respect the min/max height.

poldixd commented 7 months ago

Yes, that makes sense. Maybe I add two methods like disabledMaxHeight and disabledMinHeight for the disabled view?

TinyEditor::make('imprint')
    ->maxHeight(200)
    ->disabledMaxHeight(200)
    ->disabled()
    ->columnSpanFull(),
mohamedsabil83 commented 7 months ago

What about ->previewMaxHeight() and ->previewMinHeight()?

mohamedsabil83 commented 7 months ago

Thank you

poldixd commented 7 months ago

Thank you for merging and the work on this plugin!