feat: enable file uploads on links and media

mohamedsabil83 / filament-forms-tinyeditor

A TinyMce Editor component for filament

MIT License

164 stars 37 forks source link

feat: enable file uploads on links and media #115

Closed brendoLoR closed 6 months ago

brendoLoR commented 6 months ago

this PR enable the "upload" button on "links" and "media"

According to TinyMCE documentation for enable this functionality you must declare "file_picker_callback" function on tinyEditor initialization.

more info: https://www.tiny.cloud/docs/tinymce/6/image/#file_picker_callback

mohamedsabil83 commented 6 months ago

Could you let me know if you checked it carefully on your side? This package adopts v5 of the TinyEditor, and you mentioned a link for v6, but I believe it's the same in both. I'll test it either at this weekend and merge it. By the way, v3 of this package will support both v5 & v6 of TinyEditor, and dev can control which version from the configuration. I am busy during these periods, but I'll try to get time soon.

brendoLoR commented 6 months ago

My apologies for the wrong reference. But it's the same rule on both versions.

We use your package on many websites, and everytime the user needs to upload a file on a link we implement a CustomTinyEditor with the same code in this PR

mohamedsabil83 commented 6 months ago

Thanks for your contribution.