search

mohamedsabil83 / filament-forms-tinyeditor

A TinyMce Editor component for filament
MIT License
164 stars 37 forks source link

[Bug]: Too many localization asset files #78

Closed shirokovnv closed 1 year ago

shirokovnv commented 1 year ago

What happened?

Hello!

First of all, thank you for your great effort and awesome TinyMCE plugin.

I have more a question rather than a bug:

Is there a way to reduce the number of publicated assets, especially lang files ?

To be honest, I dont need all of them. The "eng" will be enough.

Can you provide a solution to optimize publishing?

Thanks!

How to reproduce the bug

php artisan vendor:publish --tag="filament-forms-tinyeditor-assets"

expected behaviour:

the number of lang files reduced.

Package Version

1.7.3

PHP Version

8.1

Laravel Version

10.0

Which operating systems does with happen with?

No response

Notes

No response

mohamedsabil83 commented 1 year ago

Hello @shirokovnv, thank you for the nice words. I hope you found the package helpful. The point that you mentioned is one of the other points that I plan to include in the next major version after I have time to work on it. My primary idea is to publish the English translation only. For additional translation, I'll add a new command to publish a selected language. We'll see what the final idea I'm going to implement.

shirokovnv commented 1 year ago

Thanks a lot! Looking forward to see the next version!