search

mohamedsabil83 / filament-forms-tinyeditor

A TinyMce Editor component for filament
MIT License
164 stars 37 forks source link

Add hook for removing tinymce instance #84

Closed howdu closed 11 months ago

howdu commented 11 months ago

Fix an issue when using TinyEditor inside a repeater and you add/remove the repeater item. 

Forms\Components\Repeater::make('test')
  ->schema([
      TinyEditor::make('editor')
  ])

https://github.com/mohamedsabil83/filament-forms-tinyeditor/assets/533658/86d664a9-6a50-4dd3-a0a7-1a9a842caba1

With fix

https://github.com/mohamedsabil83/filament-forms-tinyeditor/assets/533658/6c0c5a8f-91f5-460f-a26c-8b8998def262

mohamedsabil83 commented 11 months ago

Before this, update to the latest version and force push the assets and try

howdu commented 11 months ago

Yes using version v1.7.4 and ran php artisan vendor:publish --tag="filament-forms-tinyeditor-assets" --force

mohamedsabil83 commented 11 months ago

I can't reproduce your issue but as it is fixed I'll merge it

mohamedsabil83 commented 11 months ago

Thank you. Let me know if everything works as expected.