[Bug]: Editor in modal break when opened second time

[rahmanramsi]

What happened?

How to reproduce the bug

• Create an action with modal form.
• Add TinyEditor field inside it.
• Open the modal. it will work as expected.
• Close the modal, and then open again.
• TinyEditor field doesn't work

Package Version

2.0.1

PHP Version

8.1.22

Laravel Version

10.19.0

Which operating systems does with happen with?

macOS

Notes

No response

[mohamedsabil83]

Any issues appear in the browser console?

[olehlong]

Try this version https://github.com/olehlong/filament-forms-tinyeditor/blob/2.x/resources/views/tiny-editor.blade.php . I have a slightly modified local version in my project, so I'm not sure it will work in the plugin. Just adding destroy to x-data without Editor variable might work as well

destroy: () => tinymce.get('tiny-editor-{{ $getId() }}')?.remove()

but it didn't work in a custom page's action form. Firefox throws an error sometimes, but editor still works every time.

Edit: although destroy() function and editor variable are not needed (editor is already undefined when destroy called) and just using createEditor and render works:

let editor = tinymce.createEditor('tiny-editor-{{ $getId() }}', {
...
editor.render();

[mohamedsabil83]

By saying it didn't work in a custom page's action form you mean outside panel?

[olehlong]

No, inside a panel. Custom resource page https://filamentphp.com/docs/3.x/panels/resources/custom-pages with an action modal form https://filamentphp.com/docs/3.x/actions/modals#modal-forms

[mohamedsabil83]

I just released a new tag. Can you check?

[rahmanramsi]

@mohamedsabil83 its working now