search

mohamedsamara / mern-ecommerce

:balloon: Fullstack MERN Ecommerce Application
https://mern-store-gold.vercel.app
MIT License
1.63k stars 770 forks source link

Dockerised the project and updated the README.md #219

Closed creatorshubham closed 8 months ago

creatorshubham commented 8 months ago

This PR is for the #217 issue

Fixes #217

vercel[bot] commented 8 months ago

Someone is attempting to deploy a commit to a Personal Account owned by @mohamedsamara on Vercel.

@mohamedsamara first needs to authorize it.

creatorshubham commented 8 months ago

Hi @mohamedsamara , please have a look and let me know if anything else is required here.

mohamedsamara commented 8 months ago

Hey @creatorshubham! Thanks for the PR. I'll take a look soon. Looks good! I will test it on my machine.

mohamedsamara commented 8 months ago

Hey @creatorshubham! Were you able to see the app running in the browser when running docker compose up? I pulled the changes locally and ran the container but I wasn't able to see the app on browser. I think the app is not exposed outside the container.

creatorshubham commented 8 months ago

Hey @mohamedsamara , yes, I am able to access the app on the browser after running docker compose up. It is getting exposed on the 8080 port on your localhost. Please make sure that 8080 port is not already occupied by some other app or service.

If that port is free then the app will be accessible on localhost:8080

Also please make sure that port 3000 is free where our server will be started. It will be also accessible on localhost:3000

creatorshubham commented 8 months ago

Hi @mohamedsamara, did you get the chance to verify it on your local system?

mohamedsamara commented 8 months ago

@creatorshubham Thanks for the PR. Just merged the changes 👍