mohamicorp / stash-jenkins-postreceive-webhook

Webhook used to notify Jenkins when commits are made to Stash
Other
138 stars 98 forks source link

Error message in hook settings popup when SSH is disabled #101

Closed stengerh closed 9 years ago

stengerh commented 9 years ago

If SSH is disabled in the Stash server settings the plugin displays an error popup in Stash 3.x when I open the hook's settings. The popup can be closed by clicking its close button and the settings can be used normally. I traced this to an error code 500 coming from the config endpoint. The cause of the error is in the call to SshCloneUrlResolver.getCloneUrl(Repository). On Stash 3.x this method throws an IllegalStateException when SSH is disabled.

I tested this with Stash 2.4.0, 3.0.0 and 3.5.1. On 2.x the error does not occur.