Closed stengerh closed 9 years ago
Thanks for the pull request!
I'm going to merge this locally and work to flat out remove the SSH option if SSH is disabled. So, this'll get merged shortly when I push back up.
Alright. I did not want to touch the UI as I am still new to the whole Atlassian Plugin SDK. I am looking forward to the new version.
Thanks for the nice plugin, by the way!
No worries at all. I'm still learning new pieces about the SDK all the time.
And you're quite welcome for the plugin! It's been pretty neat to watch it go from the "it's something I made for myself, so why not make it available for others" to becoming the most popular plugin outside of the Atlassian Labs plugins. Pretty nuts!
This is a quick fix for #101. The config endpoint simply returns an empty string for the SSH clone URL if SSH is disabled. I made no effort to disable the SSH option in the hook's settings UI. I tested this change on Stash 2.4.0, 3.0.0 and 3.5.1.